Fix size of hero heading in some cases #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please share more of what you are seeing and why. I cannot reproduce: 
|
|
I didn't change anything to get the screenshot I shared, that's how it looked on my machine:
I just visited the website on Gnome Web (WebKit based browser) and it looks just fine: |
|
I’m seeing this too on Chrome Linux, but only if the window width is greater than 1215px. |
wooorm
approved these changes
Jun 17, 2024
wooorm
changed the title
wooorm
added
💪 phase/solved
|
Thanks! :) |
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description
I noticed that the heading of the hero section is spanning in 3 lines, leaving quite some blank in the 2nd line. I thought that condensing it to 2 lines would result in a much better and cleaner layout, hence this PR.
Before:
After:
I'd love to hear your thoughts about this.
Changes
I decreased the font size of the heading from
6rem(or 108px) to5.9rem(or 106.2px).